Skip to content

Optimize log4net log injection and refactor log providers#1489

Merged
kevingosse merged 1 commit into
masterfrom
kevin/log4net_optim
May 27, 2021
Merged

Optimize log4net log injection and refactor log providers#1489
kevingosse merged 1 commit into
masterfrom
kevin/log4net_optim

Conversation

@kevingosse

Copy link
Copy Markdown
Contributor

log4net benchmark:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Old 127.0 us 2.07 us 1.93 us 0.2441 - - 27.71 KB
New 116.2 us 1.96 us 1.64 us - - - 9.91 KB

@kevingosse
kevingosse requested a review from a team as a code owner May 25, 2021 14:53
@kevingosse kevingosse changed the title Optimize log4net and refactor log providers Optimize log4net log injection and refactor log providers May 25, 2021

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

@tonyredondo tonyredondo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevingosse
kevingosse merged commit 2e2b916 into master May 27, 2021
@kevingosse
kevingosse deleted the kevin/log4net_optim branch May 27, 2021 16:12
@andrewlock andrewlock added type:performance Performance, speed, latency, resource usage (CPU, memory) type:refactor labels Jun 1, 2021
@andrewlock andrewlock added this to the 1.27.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:performance Performance, speed, latency, resource usage (CPU, memory) type:refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants