Skip to content

Add DuckInclude attribute#1487

Merged
kevingosse merged 1 commit into
masterfrom
kevin/duck_include
May 25, 2021
Merged

Add DuckInclude attribute#1487
kevingosse merged 1 commit into
masterfrom
kevin/duck_include

Conversation

@kevingosse

Copy link
Copy Markdown
Contributor

Add a DuckInclude attribute to force the ducktyping library to include overriden base object methods.

This will be used in log4net log injection to override ToString.

@kevingosse
kevingosse requested a review from a team as a code owner May 25, 2021 11:22

@tonyredondo tonyredondo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo
tonyredondo requested a review from a team May 25, 2021 11:47
@kevingosse
kevingosse merged commit c413cd2 into master May 25, 2021
@kevingosse
kevingosse deleted the kevin/duck_include branch May 25, 2021 14:51
@andrewlock andrewlock added the type:enhancement Improvement to an existing feature label Jun 1, 2021
@andrewlock andrewlock added this to the 1.27.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants