Skip to content

_dd.origin tag improvements.#1481

Merged
tonyredondo merged 13 commits into
masterfrom
tony/dd-origin-implementation
May 25, 2021
Merged

_dd.origin tag improvements.#1481
tonyredondo merged 13 commits into
masterfrom
tony/dd-origin-implementation

Conversation

@tonyredondo

@tonyredondo tonyredondo commented May 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This PR includes the changes and improvements for Synthetics and CIApp over the internal _dd.origin tag.

Benchmarks:

Time in microseconds.

// * Summary *

BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19042
Intel Xeon CPU E5-2673 v3 2.40GHz, 1 CPU, 4 logical and 2 physical cores
.NET Core SDK=5.0.201
[Host] : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT
Job-QUYPTY : .NET Framework 4.8 (4.8.4341.0), X64 RyuJIT
Job-FQLGSK : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT

IterationTime=1.5000 s

Method Toolchain Mean Error StdDev Allocated
WriteAndFlushTraces net472 611.3 us 10.27 us 10.09 us 3.03 KB
WriteAndFlushTraces netcoreapp3.1 482.3 us 7.40 us 6.92 us 2.45 KB
WriteAndFlushEnrichedTraces net472 821.9 us 11.94 us 10.58 us 3.03 KB
WriteAndFlushEnrichedTraces netcoreapp3.1 641.6 us 8.43 us 7.48 us 2.45 KB
WriteAndFlushTracesWithOrigin net472 712.7 us 13.93 us 15.48 us 3.03 KB
WriteAndFlushTracesWithOrigin netcoreapp3.1 537.6 us 10.29 us 10.57 us 2.45 KB
WriteAndFlushEnrichedTracesWithOrigin net472 900.3 us 9.71 us 8.61 us 3.03 KB
WriteAndFlushEnrichedTracesWithOrigin netcoreapp3.1 689.2 us 9.99 us 9.34 us 2.45 KB

Performance impact over 1000 spans.

WriteAndFlushTraces/net472 = +101.4 us [max error 24.2 us]
WriteAndFlushTraces/netcoreapp3.1 = +55.3 us [max error 17.69 us]

WriteAndFlushEnrichedTraces/net472 = +78.4 us [max error 21.65 us]
WriteAndFlushEnrichedTraces/netcoreapp3.1 = +47.6 us [max error 18.42 us]

@DataDog/apm-dotnet

@tonyredondo tonyredondo self-assigned this May 21, 2021
@tonyredondo
tonyredondo force-pushed the tony/dd-origin-implementation branch from 1df2019 to 80623ed Compare May 24, 2021 08:46
@tonyredondo
tonyredondo marked this pull request as ready for review May 24, 2021 12:10
@tonyredondo
tonyredondo requested a review from a team as a code owner May 24, 2021 12:10
andrewlock
andrewlock approved these changes May 24, 2021
View reviewed changes

@andrewlock andrewlock left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though some issues with integration tests 😉

Comment thread test/Datadog.Trace.IntegrationTests/OriginTagSendTraces.cs
@tonyredondo
tonyredondo requested a review from a team May 24, 2021 13:01
@tonyredondo
tonyredondo force-pushed the tony/dd-origin-implementation branch from 4a93c7f to 13924ba Compare May 24, 2021 14:13
kevingosse
kevingosse reviewed May 24, 2021
View reviewed changes
Comment thread src/Datadog.Trace/Tagging/TagsList.cs Outdated
zacharycmontoya
zacharycmontoya reviewed May 24, 2021
View reviewed changes
Comment thread test/benchmarks/Benchmarks.Trace/AgentWriterBenchmark.cs Outdated
zacharycmontoya
zacharycmontoya approved these changes May 24, 2021
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tonyredondo
tonyredondo force-pushed the tony/dd-origin-implementation branch from 64eb125 to 42448af Compare May 25, 2021 08:40
@tonyredondo
tonyredondo merged commit 974304b into master May 25, 2021
@tonyredondo
tonyredondo deleted the tony/dd-origin-implementation branch May 25, 2021 12:48
@pellared pellared mentioned this pull request May 31, 2021
Merged
@andrewlock andrewlock added type:performance Performance, speed, latency, resource usage (CPU, memory) area:ci-visibility labels Jun 1, 2021
@andrewlock andrewlock added this to the 1.27.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@andrewlock andrewlock andrewlock approved these changes
+1 more reviewer
@kevingosse kevingosse kevingosse left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tonyredondo tonyredondo

Labels

area:ci-visibility type:performance Performance, speed, latency, resource usage (CPU, memory)

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tonyredondo @kevingosse @zacharycmontoya @andrewlock