Optimize log injection with NLog#1475
Merged
Merged
Conversation
kevingosse
added
the
type:performance
andrewlock
approved these changes
May 19, 2021
tonyredondo
approved these changes
May 19, 2021
zacharycmontoya
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of registering the values of the properties for each span created, register properties for each trace and have those fetch the active span.
Since Serilog and NLog now use a very similar logic, I think there's some refactoring to do. But I'm going to optimize log4net first so I can refactor them all at once.