Fix Call opcode in DuckTyping on struct targets.#1469
Merged
Conversation
tonyredondo
changed the title
tonyredondo
marked this pull request as ready for review
May 16, 2021 19:04
tonyredondo
added
area:call-target
type:bug
area:duck-typing
and removed
area:call-target
labels
andrewlock
approved these changes
May 17, 2021
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Thanks for figuring this one out!
| [DuckIgnore] | ||
| public string GetValue() => Value.ToString(); | ||
|
|
||
| public abstract int GetAnswerToMeaningOfLife(); |
lucaspimentel
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes methods and properties calls on DuckTyping over struct targets by changing the
CallVirtto aCallopcode.A strange behavior was observed on net461 in Release mode when using
CallVirtopcode. With this fix the DuckType test suite passes in bothDebugandRelease.This PR has been tested in all 8 pipelines available.
@DataDog/apm-dotnet