Skip to content

Fix CallTarget resilience on integrations with async continuations#1458

Merged
tonyredondo merged 3 commits into
masterfrom
tony/calltarget-async-continuations-try-catch
May 12, 2021
Merged

Fix CallTarget resilience on integrations with async continuations#1458
tonyredondo merged 3 commits into
masterfrom
tony/calltarget-async-continuations-try-catch

Conversation

@tonyredondo

@tonyredondo tonyredondo commented May 11, 2021

Copy link
Copy Markdown
Member

This PR includes:

  1. Fixes the calltarget resilience on integrations with async continuatinos by wrapping the call inside a try/catch.
  2. Adds unit test cases over integrations throwing exceptions in OnMethodBegin, OnMethodEnd and OnMethodEndAsync callbacks and not crashing the app.

@DataDog/apm-dotnet

@tonyredondo tonyredondo self-assigned this May 11, 2021
@tonyredondo
tonyredondo marked this pull request as ready for review May 11, 2021 16:34
@tonyredondo
tonyredondo requested a review from a team as a code owner May 11, 2021 16:34
@tonyredondo
tonyredondo force-pushed the tony/calltarget-async-continuations-try-catch branch from 4deeac1 to e55eed6 Compare May 11, 2021 16:41

@kevingosse kevingosse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyredondo
tonyredondo requested a review from a team May 12, 2021 10:30
@tonyredondo
tonyredondo merged commit 33ca4af into master May 12, 2021
@tonyredondo
tonyredondo deleted the tony/calltarget-async-continuations-try-catch branch May 12, 2021 19:26
@andrewlock andrewlock added this to the 1.27.0 milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants