CIApp: Testing frameworks integrations test suite and fixes#1317
Merged
Conversation
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
from
April 5, 2021 16:57
fdbb0a8 to
8ff0c56
Compare
tonyredondo
added
the
status:work-in-progress
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
from
April 9, 2021 08:41
b856ceb to
2950176
Compare
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
from
April 20, 2021 13:25
d1ab1ad to
f14881f
Compare
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
4 times, most recently
from
May 7, 2021 09:46
7efd8ee to
330d979
Compare
tonyredondo
changed the title
tonyredondo
removed
the
status:work-in-progress
tonyredondo
marked this pull request as ready for review
May 7, 2021 13:22
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
2 times, most recently
from
May 11, 2021 16:39
58e009a to
3f1c0b3
Compare
tonyredondo
force-pushed
the
tony/ciapp-test-suite
branch
from
May 18, 2021 10:23
18ba020 to
aac2aae
Compare
andrewlock
approved these changes
May 19, 2021
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
LGTM AFAICT, added a few comments/questions :)
Co-authored-by: Andrew Lock <[email protected]>
| span.Type = SpanTypes.Test; | ||
| span.SetTraceSamplingPriority(SamplingPriority.AutoKeep); | ||
| span.ResourceName = $"{testSuite}.{testName}"; | ||
| span.SetTag(TestTags.Suite, testSuite); |
Contributor
There was a problem hiding this comment.
This seems like an appropriate time to create a new TestTags type that implements ITags, but that doesn't need to happen in this PR
Member
Author
There was a problem hiding this comment.
Yeah all the ITags work came after the test frameworks integrations, I'll update the implementation in another PR.
zacharycmontoya
approved these changes
May 20, 2021
zacharycmontoya
left a comment
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good! I left some small comments but nothing blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
@DataDog/apm-dotnet