Replace log messages using string.Format style with structured log style#1163
Merged
Conversation
Closed
zacharycmontoya
approved these changes
Jan 25, 2021
lucaspimentel
approved these changes
Jan 25, 2021
Member
Author
|
Integration tests failing due to out of drive space, and all safe changes, so merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial cleanup of log levels before implementing remainder of the logging RFC
Replaces string.Format() style log templates (
"{0},{1}") with named arguments ("{Name},{Value}"). Doesn't make much difference atm, as we're only writing to file, but is better practice, and will be better if we do structured logging down the line instead.Extracted from #1150 as there concerns around following the RFC in that PR, and this change is independent
@DataDog/apm-dotnet