Remove ContainerTagsHash Log.Error on .NET Framework

bouwkast · bouwkast · commit 2893a40926a2 · 2026-03-24T17:06:46.000-04:00
Instead of guarding the caller with #if !NETFRAMEWORK, make the setter a silent no-op. This avoids conflict with #8061 which replaces the caller entirely.
diff --git a/tracer/src/Datadog.Trace/Agent/DiscoveryService/DiscoveryService.cs b/tracer/src/Datadog.Trace/Agent/DiscoveryService/DiscoveryService.cs
@@ -306,14 +306,12 @@ internal bool RequireRefresh(string? currentHash, DateTimeOffset utcNow)
 
         private async Task ProcessDiscoveryResponse(IApiResponse response)
         {
-#if !NETFRAMEWORK
             // Extract and store container tags hash from response headers
             var containerTagsHash = response.GetHeader(AgentHttpHeaderNames.ContainerTagsHash);
             if (containerTagsHash != null)
             {
                 _containerMetadata.ContainerTagsHash = containerTagsHash;
             }
-#endif
 
             // Grab the original stream
             var stream = await response.GetStreamAsync().ConfigureAwait(false);
diff --git a/tracer/src/Datadog.Trace/PlatformHelpers/ContainerMetadata.NetFramework.cs b/tracer/src/Datadog.Trace/PlatformHelpers/ContainerMetadata.NetFramework.cs
@@ -5,9 +5,6 @@
 
 #nullable enable
 
-using System.Threading;
-using Datadog.Trace.Logging;
-
 #if NETFRAMEWORK
 
 namespace Datadog.Trace.PlatformHelpers;
@@ -17,9 +14,6 @@ namespace Datadog.Trace.PlatformHelpers;
 /// </summary>
 internal sealed class ContainerMetadata
 {
-    private static readonly IDatadogLogger Log = DatadogLogging.GetLoggerFor(typeof(ContainerMetadata));
-    private static bool _warnedOnSet; // to log only once
-
     public static readonly ContainerMetadata Instance = new();
 
     private ContainerMetadata()
@@ -36,14 +30,7 @@ public ContainerMetadata(string containerId, string entityId)
     public string? ContainerTagsHash
     {
         get => null;
-        set
-        {
-            if (!_warnedOnSet)
-            {
-                _warnedOnSet = true;
-                Log.Error("The code is trying to set the value '{Value}' to {Prop}, but this has no effect in .NET Framework.", value, nameof(ContainerTagsHash));
-            }
-        }
+        set { }
     }
 
     /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -306,14 +306,12 @@ internal bool RequireRefresh(string? currentHash, DateTimeOffset utcNow)`
`306`	`306`
`307`	`307`	`private async Task ProcessDiscoveryResponse(IApiResponse response)`
`308`	`308`	`{`
`309`		`-#if !NETFRAMEWORK`
`310`	`309`	`// Extract and store container tags hash from response headers`
`311`	`310`	`var containerTagsHash = response.GetHeader(AgentHttpHeaderNames.ContainerTagsHash);`
`312`	`311`	`if (containerTagsHash != null)`
`313`	`312`	`{`
`314`	`313`	`_containerMetadata.ContainerTagsHash = containerTagsHash;`
`315`	`314`	`}`
`316`		`-#endif`
`317`	`315`
`318`	`316`	`// Grab the original stream`
`319`	`317`	`var stream = await response.GetStreamAsync().ConfigureAwait(false);`