Configure parametric test to get the cpp tracer in same way as system-tests#86
Conversation
BenchmarksBenchmark execution time: 2024-01-08 10:49:26 Comparing candidate commit 5985edc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
robertomonteromiguel
requested review from
cgilmour and
dmehala
and removed request for
dmehala
| DD_TRACE_CPP_COMMIT: << pipeline.git.revision >> | ||
| command: cd system-tests && ./build.sh -i runner && ./run.sh PARAMETRIC --log-cli-level=DEBUG | ||
| command: | | ||
| echo "https://github.com/DataDog/dd-trace-cpp@$DD_TRACE_CPP_COMMIT" > ~/project/system-tests/binaries/cpp-load-from-git |
There was a problem hiding this comment.
If it will work once we merge the PR: DataDog/system-tests#1983
There was a problem hiding this comment.
Could you just set the version of dd-trace-cpp instead of the whole github url?
There was a problem hiding this comment.
It is to maintain a certain similarity with other tracers. ie: https://github.com/DataDog/system-tests/blob/main/utils/scripts/load-binary.sh#L230
Co-authored-by: Damien Mehala <[email protected]>
robertomonteromiguel
deleted the
robertomonteromiguel/parameric_tests_set_cpp_tracer
branch
2 participants
Configure parametric test to get the cpp tracer in same way as system-tests
Related with system-tests PR: DataDog/system-tests#1983