[ci-chore] Add system tests to our pipeline#81
Merged
Conversation
dmehala
commented
Dec 18, 2023
Comment on lines
+140
to
+143
| filters: | ||
| branches: | ||
| only: | ||
| - main |
Contributor
Author
There was a problem hiding this comment.
We might want to revisit this filter. For now, it only run on main, it would be better to run it on every commit but that thing take 7m.
dmehala
commented
Dec 18, 2023
| name: Run | ||
| environment: | ||
| TEST_LIBRARY: cpp | ||
| DD_TRACE_CPP_COMMIT: << pipeline.git.revision >> |
Contributor
Author
There was a problem hiding this comment.
- Update
system-teststo build the cpp server on a specific commit id.
dmehala
commented
Dec 18, 2023
Comment on lines
+82
to
+83
| machine: | ||
| image: ubuntu-2004:current |
Contributor
Author
There was a problem hiding this comment.
It may be interesting to update our ci image and use a docker executor instead... but it's docker inside docker, it might be problematic.
Contributor
Author
There was a problem hiding this comment.
or could be fine, we run docker inside docker in nginx-datadog.
dgoffredo
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.