Description

During my attempt to use nginx-datadog instead of the legacy nginx-opentracing module in system-tests. I found out dd-trace-cpp was crashing because of this odd DD_TAGS expression.

Let me save you a click (the link is here for context):

ENV DD_TAGS='key1:val1, key2 : val2 '

Investigation

I found this RFC from 2021 to support space separation in DD_TAGS.

Our implementation does not follow the recommend solution of this RFC and end up mixing spaces and commas. The result of our algorithm is:

While it should be as follow according to the RFC:

const std::vector<StringView> tags {
   {"key1:val1"},
   {"key2 : val2"}
};