-
Notifications
You must be signed in to change notification settings - Fork 20
Comparing changes
Open a pull request
base repository: DataDog/dd-trace-cpp
base: v2.1.0
head repository: DataDog/dd-trace-cpp
compare: v2.1.1
- 13 commits
- 20 files changed
- 7 contributors
Commits on May 6, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 1be1b15 - Browse repository at this point
Copy the full SHA 1be1b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c6ce72 - Browse repository at this point
Copy the full SHA 5c6ce72View commit details
Commits on May 7, 2026
-
Configuration menu - View commit details
-
Copy full SHA for b76b200 - Browse repository at this point
Copy the full SHA b76b200View commit details -
build(deps): bump the gh-actions-packages group with 3 updates (#277)
Updates `actions/checkout` from 6.0.1 to 6.0.2 Updates `github/codeql-action` from 4.31.9 to 4.32.0 Updates `actions/upload-artifact` from 5.0.0 to 6.0.0
Configuration menu - View commit details
-
Copy full SHA for d816b62 - Browse repository at this point
Copy the full SHA d816b62View commit details -
build(deps): bump the bazel-packages group with 2 updates (#318)
Updates `platforms` from 1.0.0 to 1.1.0 Updates `rules_cc` from 0.2.14 to 0.2.18
Configuration menu - View commit details
-
Copy full SHA for 1c011f6 - Browse repository at this point
Copy the full SHA 1c011f6View commit details
Commits on May 11, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 34520f2 - Browse repository at this point
Copy the full SHA 34520f2View commit details
Commits on May 18, 2026
-
ci: adding scheduled runs for system-tests (#315)
* ci: adding scheduled runs for system-tests * test * Fix dev call * Remove test * Remove API key * Cleanup
Configuration menu - View commit details
-
Copy full SHA for 90d9267 - Browse repository at this point
Copy the full SHA 90d9267View commit details
Commits on May 26, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 8563501 - Browse repository at this point
Copy the full SHA 8563501View commit details
Commits on Jun 3, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 5a576f7 - Browse repository at this point
Copy the full SHA 5a576f7View commit details
Commits on Jun 8, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 93ed055 - Browse repository at this point
Copy the full SHA 93ed055View commit details
Commits on Jun 9, 2026
-
fix(telemetry): refactor to shared_ptr and add deterministic shutdown…
…() (#326) * fix(telemetry): refactor to shared_ptr and add deterministic shutdown() Refactors Telemetry to be heap-allocated via a shared_ptr (enable_shared_from_this + factory create()). Scheduled-task callbacks now capture a weak_from_this() so they become no-ops automatically once the object is no longer reachable. Move semantics are removed. Adds a shutdown() function that cancels scheduled tasks, sends the app-closing payload, and releases the HTTP client. After the call, all HTTP sending becomes a no-op: send_payload() snapshots http_client_ under http_client_mutex_ and returns early if null. http_client_ is reset under the same mutex in shutdown(), so any concurrent call that already holds a live snapshot completes cleanly while new calls short-circuit. If this is the last shared_ptr to the client, the background Curl thread is joined at that point. Rationale: shutdown() cannot guarantee that, after it returns, there are no in-flight HTTP callbacks still holding a reference to Telemetry state. Using a shared_ptr ensures any late callback finds a dead weak_ptr and short-circuits instead of accessing a destroyed object. The load-bearing weak_from_this() captures are the on_response and on_error lambdas inside send_payload(). Those run on CurlImpl's independent event_loop_ thread (via handle_message()), which has no blocking-cancel mechanism. app_closing() calls drain() with a 2-second deadline, so if the agent is slow, requests can still be in flight on the curl thread after shutdown() returns. The weak.lock() guard is what prevents a use-after-free in that window. The weak_from_this() captures in the scheduled-task callbacks (schedule_tasks()) are defense-in-depth for a different concern: ThreadedEventScheduler's cancel() blocks until any in-progress callback finishes, making those captures redundant against the threaded scheduler. However, the EventScheduler interface does not mandate a blocking cancel(), so the captures guard against non-blocking implementations where a callback could otherwise touch Telemetry state after it has been torn down. Also fixes a race in test_span.cpp: disabling telemetry there prevents app_started() from posting to the Curl background thread, which would otherwise fail to reach the (absent) agent asynchronously and call log_error() on the shared MockLogger, racing against the error_count == 0 assertion. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * fix comment wording * run clang-format --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2952e1f - Browse repository at this point
Copy the full SHA 2952e1fView commit details
Commits on Jun 11, 2026
-
Configuration menu - View commit details
-
Copy full SHA for d0605a7 - Browse repository at this point
Copy the full SHA d0605a7View commit details
Commits on Jun 16, 2026
-
Capture proxy related environment variables at Curl client constructi…
…on to avoid crash (#328)
Configuration menu - View commit details
-
Copy full SHA for 0a1dc56 - Browse repository at this point
Copy the full SHA 0a1dc56View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.1.0...v2.1.1