Add sds_excluded_namespace tag to multipass excluded match metric#348
Merged
Add sds_excluded_namespace tag to multipass excluded match metric#348
Conversation
When debug observability is enabled, the false_positive.multipass.excluded_match metric now includes an sds_excluded_namespace tag identifying which excluded path contributed the match that caused the false positive. Changes: - excluded_matches changed from AHashSet<String> to AHashMap<String, String> to track the contributing path as a pre-formatted string - TruePositiveSearch stores a &Path reference (zero-cost) and only calls to_string() at the insert point when debug observability is enabled; otherwise stores an empty string (no allocation) - Added multipass_excluded_scan benchmark to catch performance regressions Benchmark (multipass_excluded_scan): main (baseline): 27.0 µs this branch: 26.7 µs (no regression)
trosenblatt
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDS-2471
Adds
sds_excluded_namespacetag tofalse_positive.multipass.excluded_matchmetric whenenable_debug_observabilityis enabled. Zero-cost when disabled.Benchmark (
multipass_excluded_scan, ~260 paths):into_static()every call)