Add sds_excluded_namespace tag to multipass excluded match metric#346
Merged
Add sds_excluded_namespace tag to multipass excluded match metric#346
Conversation
When debug observability is enabled, the false_positive.multipass.excluded_match metric now also includes a sds_excluded_namespace tag identifying which excluded path contributed the match that caused the false positive. The excluded_matches set is changed from AHashSet<String> to AHashMap<String, Path<'static>> so the contributing path is tracked from insertion through to metric emission.
vinckama
force-pushed
the
vincent.roy/3585
branch
from
b83d81d to
c8c86e8
Compare
trosenblatt
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When debug observability is enabled, the
false_positive.multipass.excluded_matchmetric now includes a second tagsds_excluded_namespacealongside the existingsds_namespacetag. This provides visibility into which excluded scope path contributed the match that caused the exclusion, making it easier to debug false positive behavior in multipass scanning.To track which excluded path contributed each match string,
excluded_matcheswas changed fromAHashSet<String>toAHashMap<String, Path<'static>>, andTruePositiveSearchnow carries thescan_pathso it is available at insertion time.Builds on PR #344 which introduced the
sds_namespacetag andenable_debug_observabilityfeature flag.SDS-2471
Part of the debug observability improvements for the Sensitive Data Scanner.