Skip to content

[CHORE] Rename test model classes with DD prefix and simplify Exporter naming#263

Merged
ypopovych merged 2 commits into
mainfrom
chore/rename-test-models-and-exporter
May 27, 2026
Merged

[CHORE] Rename test model classes with DD prefix and simplify Exporter naming#263
ypopovych merged 2 commits into
mainfrom
chore/rename-test-models-and-exporter

Conversation

@ypopovych

@ypopovych ypopovych commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Renames the public test model types to avoid the collision between the existing Test class and Testing.Test from the swift-testing framework, and gives the exporter a less wordy name.

  • SessionDDSession
  • ModuleDDModule
  • SuiteDDSuite
  • TestDDTest
  • EventsExporter (class) → Exporter
  • EventsExporterProtocolExporterProtocol

Files were renamed to match (DDSession.swift, DDModule.swift, DDSuite.swift, Exporter.swift, DDSessionApiTests.m) and the ObjC test class inside DDSessionApiTests.m — which had a stale DDTestModuleApiTests name despite testing the session API — was renamed to DDSessionApiTests.

Module/target names are unchanged: the EventsExporter target still ships as EventsExporter, only the type inside it is shortened.

Notes

  • The @objc(...) parenthesized ObjC name was dropped from each class because the Swift name now matches the desired ObjC name verbatim.
  • Tests/fixtures/symbols-sdk.log is intentionally left referencing the old DDTestModuleApiTests / DDTestSessionApiTests.m strings — it's frozen test data that FileLocatorTests.testSDKFixtureObjCMethod parses; editing it would defeat the parser test.
  • This is a breaking change for any external consumers of the Swift or ObjC public API of these classes.

Test plan

  • xcodebuild build on macOS — succeeds locally
  • xcodebuild build-for-testing on macOS — succeeds locally
  • CI: unit tests + integration tests on all supported platforms
  • CI: ObjC API smoke test (DDSessionApiTests) still exercises DDSession/DDModule/DDSuite/DDTest

🤖 Generated with Claude Code

…r naming

Renames the public test model types to avoid the collision between the
existing `Test` class and `Testing.Test` from the swift-testing framework,
and gives the exporter a less wordy name.

* `Session` -> `DDSession`
* `Module` -> `DDModule`
* `Suite` -> `DDSuite`
* `Test` -> `DDTest`
* `EventsExporter` (class) -> `Exporter`
* `EventsExporterProtocol` -> `ExporterProtocol`

Files renamed to match: `DDSession.swift`, `DDModule.swift`,
`DDSuite.swift`, `Exporter.swift`, `DDSessionApiTests.m` (and the ObjC
test class inside, which had a stale `DDTestModuleApiTests` name).

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@ypopovych
ypopovych requested review from a team as code owners May 27, 2026 11:26
@datadog-datadog-prod-us1

This comment has been minimized.

@ypopovych
ypopovych requested a review from anmarchenko May 27, 2026 13:57
@ypopovych
ypopovych merged commit 6621844 into main May 27, 2026
31 checks passed
@ypopovych
ypopovych deleted the chore/rename-test-models-and-exporter branch May 27, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants