[CHORE] Rename test model classes with DD prefix and simplify Exporter naming#263
Merged
Merged
Conversation
…r naming Renames the public test model types to avoid the collision between the existing `Test` class and `Testing.Test` from the swift-testing framework, and gives the exporter a less wordy name. * `Session` -> `DDSession` * `Module` -> `DDModule` * `Suite` -> `DDSuite` * `Test` -> `DDTest` * `EventsExporter` (class) -> `Exporter` * `EventsExporterProtocol` -> `ExporterProtocol` Files renamed to match: `DDSession.swift`, `DDModule.swift`, `DDSuite.swift`, `Exporter.swift`, `DDSessionApiTests.m` (and the ObjC test class inside, which had a stale `DDTestModuleApiTests` name). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This comment has been minimized.
This comment has been minimized.
anmarchenko
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the public test model types to avoid the collision between the existing
Testclass andTesting.Testfrom the swift-testing framework, and gives the exporter a less wordy name.Session→DDSessionModule→DDModuleSuite→DDSuiteTest→DDTestEventsExporter(class) →ExporterEventsExporterProtocol→ExporterProtocolFiles were renamed to match (
DDSession.swift,DDModule.swift,DDSuite.swift,Exporter.swift,DDSessionApiTests.m) and the ObjC test class insideDDSessionApiTests.m— which had a staleDDTestModuleApiTestsname despite testing the session API — was renamed toDDSessionApiTests.Module/target names are unchanged: the
EventsExportertarget still ships asEventsExporter, only the type inside it is shortened.Notes
@objc(...)parenthesized ObjC name was dropped from each class because the Swift name now matches the desired ObjC name verbatim.Tests/fixtures/symbols-sdk.logis intentionally left referencing the oldDDTestModuleApiTests/DDTestSessionApiTests.mstrings — it's frozen test data thatFileLocatorTests.testSDKFixtureObjCMethodparses; editing it would defeat the parser test.Test plan
xcodebuild buildon macOS — succeeds locallyxcodebuild build-for-testingon macOS — succeeds locallyDDSessionApiTests) still exercisesDDSession/DDModule/DDSuite/DDTest🤖 Generated with Claude Code