Skip to content

Remove literal quote characters from macOS xctest invocation#195

Merged
ypopovych merged 2 commits into
chore-fix-cifrom
copilot/sub-pr-193
Feb 11, 2026
Merged

Remove literal quote characters from macOS xctest invocation#195
ypopovych merged 2 commits into
chore-fix-cifrom
copilot/sub-pr-193

Conversation

Copilot AI commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Addresses feedback from PR #193 on passing '' as the 4th argument to xctest for macOS builds. Literal quotes could leak into the destination string if the function implementation changes.

Change:

# Before
$(call xctest,$*,macOS,$(XC_LOG),'')

# After
$(call xctest,$*,macOS,$(XC_LOG),)

The 4th parameter (simulator name) is unused for macOS builds—only iOS/tvOS simulator targets reference it. Omitting the argument passes an empty value without embedded quote characters.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] WIP address feedback from PR #193 on CI fixes Remove literal quote characters from macOS xctest invocation Feb 11, 2026
Copilot AI requested a review from ypopovych February 11, 2026 18:04
@ypopovych
ypopovych marked this pull request as ready for review February 11, 2026 18:09
@ypopovych
ypopovych requested review from a team as code owners February 11, 2026 18:09
@ypopovych
ypopovych merged commit 7767426 into chore-fix-ci Feb 11, 2026
1 check passed
@ypopovych
ypopovych deleted the copilot/sub-pr-193 branch February 11, 2026 18:09
ypopovych added a commit that referenced this pull request Feb 11, 2026
* Fix CI configuration for tests
* fixed OS version
* added simulated devices as parameters for CI
* Update xctest function documentation to include simulator parameter (#194)
* Fix Makefile to pass empty value instead of literal quotes (#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants