Update xctest function documentation to include simulator parameter#194
Merged
Conversation
Co-authored-by: ypopovych <[email protected]>
Copilot
AI
changed the title
[WIP] Update to address feedback on CI fix pull request
Update xctest function documentation to include simulator parameter
Feb 11, 2026
ypopovych
approved these changes
Feb 11, 2026
ypopovych
marked this pull request as ready for review
February 11, 2026 17:33
ypopovych
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
xctestfunction in the Makefile was updated in PR #193 to accept a 4th parameter for simulator name (used by iOSsim and tvOSsim platforms), but the header comment still documented only 3 parameters.Changes
# params: scheme, platform, logfileto# params: scheme, platform, logfile, simulatorThe function implementation and all call sites were already correct - only the documentation was outdated.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.