[CHORE] fix ci#193
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts local/CI test execution to cope with GitHub Actions runner image updates by making simulator device selection configurable and updating the CI matrix accordingly.
Changes:
- Parameterize iOS/tvOS simulator device names in the
Makefileand allow overriding viaIOS_SIMULATOR/TVOS_SIMULATOR. - Update the Integration Tests GitHub Actions workflow to pass simulator names into
makeand refresh the Xcode/runner matrix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Makes simulator destinations configurable for iOS/tvOS test runs. |
| .github/workflows/integrationTests.yml | Updates CI jobs/matrix and passes simulator names to the Makefile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ypopovych I've opened a new pull request, #194, to work on those changes. Once the pull request is ready, I'll request review from you. |
…194) * Initial plan * Update xctest function documentation to include simulator parameter Co-authored-by: ypopovych <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ypopovych <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
@ypopovych I've opened a new pull request, #195, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix Makefile to pass empty value instead of literal quotes for macOS xctest call Co-authored-by: ypopovych <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ypopovych <[email protected]>
What and why?
Github updated their runners and broke our CI. Fixed it in this PR.
How?
Updated workflow and Makefile to run on different virtual iOS and TV sim devices
Review checklist