[SDTEST-2984] Added test.final_status tag for the tests#190
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new test.final_status span tag to report the final status outcome for a test after retries complete (i.e., the status of the last execution that is ultimately reported), and updates feature tests to validate the tag is present exactly once per test.
Changes:
- Introduce
DDTestTags.testFinalStatus = "test.final_status". - Set
test.final_statusinRetryAndSkipTags.testWillFinishonly on the final execution (including correcting fail→pass when failures are suppressed). - Extend existing feature tests (ITR, EFD, ATR) to assert
test.final_statusis set exactly once and matches the last run’s expected outcome.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Sources/DatadogSDKTesting/DDTags.swift |
Adds the new test.final_status tag constant. |
Sources/DatadogSDKTesting/RetryAndSkipTags.swift |
Populates test.final_status on the last run (and adjusts for suppressed failures). |
Tests/DatadogSDKTesting/Features/TestImpactAnalysisTests.swift |
Validates test.final_status for skipped and failed ITR scenarios. |
Tests/DatadogSDKTesting/Features/EarlyFlakeDetectionTests.swift |
Validates test.final_status across EFD retry scenarios (pass/fail) and non-retried cases. |
Tests/DatadogSDKTesting/Features/AutoTestRetriesTests.swift |
Validates test.final_status across ATR retry scenarios (pass/fail) and limits. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
What about tests for the Flaky Test Management features? Quarantine, Disabled, and Attempt to fix? |
calvinbayer
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Added
test.final_statusto the test spans, reporting the status sent to the test framework for the last retry (failed/skipped/passed) etc.How?
Add status in the
testWillFinishhook.Review checklist