RUM-2880 Prevent performance impact for internal logging#79
Merged
Conversation
0xnm
approved these changes
Jan 17, 2024
xgouchet
force-pushed
the
xgouchet/RUM-2880/isLogLevelAllowed
branch
from
January 18, 2024 07:25
df57752 to
8dc83d2
Compare
xgouchet
force-pushed
the
xgouchet/RUM-2880/isLogLevelAllowed
branch
from
January 18, 2024 07:30
8dc83d2 to
db1c5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #78
Following suggestions by @slheavner , we prevented too many rendez vous with the main thread in our internal logger by: