Clean up GitLab CI and build setup#191
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc51b02de9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kikoveiga
force-pushed
the
kikoveiga/cleanup-gitlab-ci-setup
branch
5 times, most recently
from
June 16, 2026 15:09
2e57bf7 to
d7a2a86
Compare
kikoveiga
marked this pull request as draft
June 16, 2026 15:10
kikoveiga
force-pushed
the
kikoveiga/cleanup-gitlab-ci-setup
branch
from
June 16, 2026 15:59
d7a2a86 to
79dea81
Compare
- Remove the dead publish:release stub and Slack notify jobs (publishing is handled by GitHub Actions) along with the now-empty stages and the slack-notifier include. - Switch the node before_script to npm ci and commit the root package-lock.json (ignore the ropm-generated subdir lockfiles). - Drop the redundant global npm tool installs from the image; the toolchain comes from devDependencies via npx --no-install. Bump CI_IMAGE_VERSION to 6. - Update the Roku SCA checksum (unversioned URL was republished) and switch ENV lines to key=value to clear LegacyKeyValueFormat warnings. - Stage the root package-lock.json in release.sh so version bumps stay in sync with package.json in the release commit. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
kikoveiga
force-pushed
the
kikoveiga/cleanup-gitlab-ci-setup
branch
from
June 16, 2026 16:08
79dea81 to
1518032
Compare
kikoveiga
marked this pull request as ready for review
June 16, 2026 16:13
ambushwork
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.