Clean up RUM TODOs and tests#190
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR tightens up RUM-related code/tests by removing stale TODOs, making scope activity checks return concrete booleans, and improving uploader URL handling by URL-encoding query parameter values (with corresponding test coverage).
Changes:
- Extend RUM view-scope resource tests to assert
_dd.trace_id/_dd.span_idpropagation (and invalid behavior for minimal resources). - Remove unused RUM agent test setup for
clientTokenand clean up outdated TODO comments in RUM scopes. - URL-encode uploader query-param values in
MultiTrackUploaderTaskand update tests to validate encoding behavior.
Reviewed changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/source/tests/rum/Test__RumViewScope.bs | Adds assertions for resource trace/span IDs in emitted RUM events. |
| test/source/tests/rum/Test__RumAgent.bs | Removes unused client token setup in tests. |
| test/source/tests/core/Test__MultitrackUploaderTask.bs | Adds URL-encoding regression coverage for query params. |
| library/components/rum/RumViewScope.bs | Updates header comment and removes outdated TODO. |
| library/components/rum/RumSessionScope.bs | Removes outdated TODO and makes isActive() return true. |
| library/components/rum/RumScope.bs | Makes base isActive() return true instead of invalid. |
| library/components/rum/RumApplicationScope.bs | Makes isActive() return true instead of invalid. |
| library/components/core/MultiTrackUploaderTask.bs | URL-encodes query param values when building upload URLs. |
| dist/components/rum/RumViewScope.brs | Built artifact update reflecting RumViewScope changes. |
| dist/components/rum/RumSessionScope.brs | Built artifact update reflecting RumSessionScope changes. |
| dist/components/rum/RumScope.brs | Built artifact update reflecting RumScope changes. |
| dist/components/rum/RumApplicationScope.brs | Built artifact update reflecting RumApplicationScope changes. |
| dist/components/core/MultiTrackUploaderTask.brs | Built artifact update reflecting MultiTrackUploaderTask changes. |
| cspell.json | Removes now-unused “rumm” spelling exception. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
kikoveiga
force-pushed
the
kikoveiga/cleanup-rum-todos
branch
from
June 16, 2026 17:12
2e95e70 to
2a92760
Compare
ambushwork
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.