Add missing device and Os information to RUM crash events#187
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes missing device and os fields in RUM crash (error) events by copying them from the last persisted view event when reporting a crash in a new session.
Changes:
- Add
deviceandosto the crash event payload generated from the persisted last-view file. - Extend crash reporter tests to include
device/osin the persisted view event and assert they are propagated to the crash event. - Update the built
distartifact to reflect the library change.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/source/tests/rum/Test__RumCrashReporterTask.bs | Adds fake device/os to stored view fixtures and asserts crash events inherit them. |
| library/components/rum/RumCrashReporterTask.bs | Copies device/os from lastViewEvent into the generated crash event payload. |
| dist/components/rum/RumCrashReporterTask.brs | Updates compiled output to include device/os in crash event generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kikoveiga
approved these changes
Jun 12, 2026
ambushwork
force-pushed
the
yl/fix-missing-device-info-in-crash
branch
from
June 12, 2026 12:35
9499bed to
0dbf3bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
osanddevicefields are not copied from last view when reporting crash event in a new session, this PR adds them.Review checklist (to be filled by reviewers)