Unify BrighterScript build tooling across all targets#184
Merged
Conversation
- Remove devDependencies from library/ and sample/ so all three build targets (library, test, sample) resolve bsc and bslint from the root package.json (0.69.13 / 0.8.39) — single source of truth - Fix build.sh to use rm -rf so it doesn't error when node_modules wasn't created (folders with no local devDependencies) - Rename unused `writer` param to `_writer` in RumScope stub to match the _ph convention and silence the runtime lint warning Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
ambushwork
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
library/andsample/hadbrighterscript@^0.65.1andbslint@^0.8.11pinned locally, whiletest/had no devDependencies at all and silently fell back to the root's0.69.13. This meant two different compiler versions were running during the same build.library/andsample/so all three targets now resolvebscandbslintfrom the rootpackage.json— one version, one place to update.build.shto userm -rfinstead ofrm -rso it doesn't error when a folder has no localnode_modules.writerparam to_writerin theRumScopestub to match the existing_phconvention and silence the runtime lint warning (the param must exist to satisfy the interface, but this base implementation doesn't use it).The compiler version change (
0.65.27→0.69.13) produces byte-for-byte identicaldist/output — verified by diffing before and after.🤖 Generated with Claude Code