Cleanup code and lint warnings#168
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on eliminating lint warnings across the codebase by updating the BrightScript linter and cleaning up unused/dead code, including updating assertion helpers to properly use their msg parameter.
Changes:
- Bump
@rokucommunity/bslintfrom0.8.38to0.8.39. - Update multiple
BaseAssertmethods to respect the optionalmsgparameter when throwing. - Remove unused variables/initializations in tests and task components to resolve lint warnings (and sync generated
dist/output).
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/source/tests/Test__DdUrlTransfer.bs | Removes unused test variable to satisfy lint. |
| test/source/tests/Test__datadog.bs | Removes unused variables in initialization test setup. |
| test/source/asserts/Asserts.bs | Uses msg parameter for thrown assertion messages when provided. |
| package.json | Updates @rokucommunity/bslint devDependency version. |
| library/components/rum/RumCrashReporterTask.bs | Removes unused roMessagePort initialization. |
| library/components/core/MultiTrackUploaderTask.bs | Removes unused roFileSystem initialization. |
| dist/components/rum/RumCrashReporterTask.brs | Generated output reflecting removal of unused port. |
| dist/components/core/MultiTrackUploaderTask.brs | Generated output reflecting removal of unused filesystem field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kikoveiga
force-pushed
the
kikoveiga/cleanup-dead-code
branch
from
May 30, 2026 19:17
007da65 to
759b60d
Compare
ambushwork
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rokucommunity/bslintversion0.8.38->0.8.39, which fixes a bug regarding parameters not being flagged as unused.Asserts.bswhich weren't using themsgparameter.for eachoccurrences with.appendcalls.npm run lintfinds 0 warnings.Review checklist (to be filled by reviewers)