Fix internalLogger.decToHex function#167
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
kikoveiga
force-pushed
the
kikoveiga/fix-dec-to-hex-function
branch
from
May 29, 2026 14:22
b1ec84c to
f282b28
Compare
There was a problem hiding this comment.
Pull request overview
Fixes the decToHex helper used by internal logging/error formatting by replacing the manual conversion loop (which relied on / division) with the built-in integer-to-string base conversion, and adds a dedicated unit test suite to lock in expected output.
Changes:
- Simplified
decToHex(number)toUCase(StrI(number, 16).Trim())in both source and dist outputs. - Added unit tests covering common values and the max signed 32-bit integer.
- Registered the new InternalLogger test suite in the test runner.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/source/tests/Test__internalLogger.bs | Adds unit coverage for decimal-to-hex conversion outputs. |
| test/components/TestRunner.bs | Wires the new InternalLogger test suite into the test run. |
| library/source/internalLogger.bs | Replaces manual dec→hex conversion with StrI(..., 16) + normalization. |
| dist/source/internalLogger.brs | Mirrors the same decToHex implementation change in the dist artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ambushwork
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/instead of\division.Review checklist (to be filled by reviewers)