Set operation timestamp at event creation#164
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts RUM “vital operation” timestamping so operation start/end times are captured at event creation (call site) rather than at processing time, preventing cross-thread rendezvous delays from skewing measurements (per #159).
Changes:
- Added
timestampto raw operation events (startFeatureOperation/stopFeatureOperation) at creation time. - Updated
RumSessionScope.sendVitalEventto preferevent.timestamp(fallback togetTimestamp()when absent). - Extended unit tests to validate timestamp propagation and an explicit-timestamp scenario.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/source/tests/rum/Test__RumSessionScope.bs | Adds a unit test ensuring vitalEvent.date honors an explicit event timestamp. |
| test/source/tests/rum/Test__RumAgent.bs | Strengthens tests to assert operation events include a call-site timestamp. |
| library/source/rum/rumRawEvents.bs | Sets operation timestamps at raw-event creation time and imports timeUtils. |
| library/components/rum/RumSessionScope.bs | Uses event-provided timestamp when emitting vital events to avoid processing-time skew. |
| dist/source/rum/rumRawEvents.brs | Built output: operation raw events now include timestamp: getTimestamp(). |
| dist/components/rum/RumSessionScope.brs | Built output: prefers event.timestamp when computing date. |
| dist/components/rum/RumAgent.xml | Ensures timeUtils.brs is included for runtime access to getTimestamp(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ambushwork
approved these changes
May 27, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
startOperation,succeedOperation,failOperationwhich better reflects when the operation actually started/ended as suggested in Fix Datadog operations to not include processing in measurement #159.Review checklist (to be filled by reviewers)