RUM-16359: Refactor RumAgent setup#161
Merged
Merged
Conversation
kikoveiga
force-pushed
the
kikoveiga/RUM-16359/refactor-rumagent-setup
branch
2 times, most recently
from
May 19, 2026 09:38
7013d85 to
0b9d6c8
Compare
kikoveiga
marked this pull request as ready for review
May 19, 2026 10:46
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b9d6c8939
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kikoveiga
force-pushed
the
kikoveiga/RUM-16359/refactor-rumagent-setup
branch
from
May 20, 2026 09:46
0b9d6c8 to
ae7a83d
Compare
kikoveiga
force-pushed
the
kikoveiga/RUM-16359/refactor-rumagent-setup
branch
from
May 20, 2026 09:48
ae7a83d to
b2dc69e
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RumAgentsetup initialization by using therumAgent.control = "RUN"pattern indatadogSdk. Because of this, we know that we have all the fields initialized and can cache them safely, as we now do inside theRumAgent.setup()method.DebugScreen.Motivation
RumAgentinitialization and main loop was not optimal. It would do a bunch of repeated work, callingensureUploader,ensureSetup, etc. multiple times, generating rendezvous and losing performance.Sample app init before: (57 rendezvous)
Sample app init after: (47 rendezvous)
Doing a right-click on sample app before: (13 rendezvous)
Doing a right-click on sample app after: (3 rendezvous)
Review checklist (to be filled by reviewers)