Ensure the uploader task is started once all required interface fields are set#156
Merged
Merged
Conversation
ambushwork
force-pushed
the
luyi/fix-uploader-clienttoken-race
branch
from
May 15, 2026 09:46
809a68b to
68f0bd6
Compare
ambushwork
marked this pull request as ready for review
May 15, 2026 09:50
3 tasks
kikoveiga
previously approved these changes
May 15, 2026
kikoveiga
approved these changes
May 15, 2026
ambushwork
force-pushed
the
luyi/fix-uploader-clienttoken-race
branch
from
May 15, 2026 18:06
cfe9cec to
5d8d7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A mirror PR of #155, it also adds unit test to cover the issue and fix the
.brsfilesReview checklist (to be filled by reviewers)