Merge feature/rum-operation-integration into develop#133
Merged
Conversation
Contributor
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2e22f64ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kikoveiga
approved these changes
Mar 9, 2026
Valpertui
approved these changes
Mar 9, 2026
- Add startFeatureOperation and stopFeatureOperation to RawEvent enum - Add VitalStepType enum (start, stepEnd, update, retry) with schema-defined string values - Add FailureReason enum (error, abandoned, other) with schema-defined string values Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Add startFeatureOperationEvent(name, operationKey, context) returning start event with vitalId
- Add succeedFeatureOperationEvent(name, operationKey, context) returning stop event without failureReason
- Add failFeatureOperationEvent(name, operationKey, failureReason, context) returning stop event with failureReason
- All factories use inline object literals with eventType first, matching existing convention
- UUID generated via CreateObject("roDeviceInfo").GetRandomUUID()
Co-Authored-By: Claude Opus 4.6 <[email protected]>
…spatch for operation methods - Add 3 field declarations (startOperation, succeedOperation, failOperation) to RumAgent.xml - Add 3 function declarations to RumAgent.xml interface - Register 3 field observers in RumAgent.bs init() - Add 3 dispatch branches in rumAgentLoop() event loop Co-Authored-By: Claude Opus 4.6 <[email protected]>
…ation helpers - Add startOperation, succeedOperation, failOperation public methods with input validation - Add __onStartOperation, __onSucceedOperation, __onFailOperation private handlers - Add __isValidOperationName, __isValidOperationKey, __isValidFailureReason helpers - Validate blank names, blank operationKeys, and invalid failureReasons via ddLogError - Accept invalid (nil) operationKey as valid for unkeyed operations Co-Authored-By: Claude Opus 4.6 <[email protected]>
- 6 dispatch tests verifying startOperation, succeedOperation, failOperation delegate correctly to RumScope - 6 validation tests covering blank names, whitespace names, nil keys, blank keys, whitespace keys, and invalid failure reasons Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add observeFieldScoped registrations and event loop dispatch branches for startOperation, succeedOperation, and failOperation fields in RumAgent, along with the corresponding XML field declarations. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Implement handleVitalEvent at the session scope level to construct and write JSON payloads for start/succeed/fail feature operations. Includes: - Active operation tracking with duplicate-start and missing-operation warnings - Developer warning when a vital event is emitted without an active view - Session renewal clears active operation state - Guard against invalid rumScope before calling handleEvent Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Add comprehensive tests for handleVitalEvent covering: - Correct JSON payload construction for start/succeed/fail operations - Keyed and unkeyed operation tracking - Duplicate start warnings and missing-operation warnings - No-active-view fallback behaviour - Session renewal mid-operation clears state - Context merging priority, Unicode names, long names, special characters Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Add OperationsScreen.xml with LabelList and messageLabel (matches DebugScreen pattern) - Add OperationsScreen.bs with 7 menu items covering full operation API surface - Timer-based delays: 2s content load auto-succeed, 1.5s login timeout - Keyed operation demo with random key generation - All calls use BrighterScript @. syntax with correct failOperation parameter order
…ation instrumentation
- Add operationsLabel and OperationsScreen component to MainScene.xml
- Update MainScene.bs with full navigation support (init, switchScreen, getScreenByName, getLabelByName, getNextScreen, getPreviousScreen)
- Navigation cycle: Home -> Video -> Network -> Debug -> Operations -> Home
- Add inline startOperation("playbackStart") to VideoScreen on play press
- Add onVideoStateChange: succeedOperation on "playing", failOperation on "error"
- unobserveField after completion to prevent duplicate calls
ambushwork
force-pushed
the
valpertui/feature/rum-operation-integration
branch
from
March 9, 2026 15:32
e2e22f6 to
3ed9c44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge feature/rum-operation-integration into develop
Review checklist (to be filled by reviewers)