RUM-14690: Reduce rendezvous events in RumAgent#121
Conversation
f80ee59 to
f3e852d
Compare
| m.top.observeFieldScoped("addAction", m.port) | ||
| m.top.observeFieldScoped("addError", m.port) | ||
| m.top.observeFieldScoped("addResource", m.port) | ||
| m.top.observeFieldScoped("sendCrash", m.port) |
There was a problem hiding this comment.
here it is only sendCrash removed, but below in the rumAgentLoop there is also addConfigTelemetry removed, not sure if it is right or not
There was a problem hiding this comment.
sendCrash and addConfigTelemetry are not removed, to avoid rendezvous of visiting m.top fields, these two functions are moved into updateFields function and triggered only when the m. fields are set.
only sendCrash is removed here because it should be triggered only inside RumAgent with the lastExitOrTerminationReason value from last session (should not be explicitly called) , so we stop listen the injection from outside. addConfigTelemetry is kept because we still call it from sample app and unit test.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3e852d1ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f3e852d to
62ee84a
Compare
2 participants
What does this PR do?
This PR mainly reduce the rendezvous events by:
rumScope,uploader&writerinside brightscript scope instead of visiting SceneGraph thread everytime.Results
This PR reduces the rendezvous events in application launch from 102-> 63 (38% improvements)
Additional Notes
RumAgentReview checklist (to be filled by reviewers)