Refactor RumAgent to avoid race condition#115
Merged
Conversation
ambushwork
force-pushed
the
yl/fix-rum-session-race-condition
branch
from
February 11, 2026 16:10
2415d19 to
6c62437
Compare
0xnm
reviewed
Feb 11, 2026
0xnm
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue to fix
Before the race conditions happens when
rumAgentLoop(running on task thread) try to createrumScope, while at the same timestartViewis called from BrightScript main thread, they enter in the if blockensureRumScopealmost` the same time, causing two scopes are created, thus customers will see two session in the explorer, one containing only the first view with very short duration, the other is normal.How this fix works
instead of directly triggering
ensureRumScopefrom the thread of callsite, we send the event to theportof this task to which the task is always listening, oncerumAgentLoopreceives the event, it will be handled always in the task thread.Additional Notes
Some other fix:
rumAgentLoopsince it's a outdated conceptReview checklist (to be filled by reviewers)