Skip to content

RUMS-4872: Add missing BrighterScript Callfunc Operator to fix crash#106

Merged
ambushwork merged 6 commits into
release/1.3.0from
yl/fix-telemetry-crash
Sep 8, 2025
Merged

RUMS-4872: Add missing BrighterScript Callfunc Operator to fix crash#106
ambushwork merged 6 commits into
release/1.3.0from
yl/fix-telemetry-crash

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

In previous change, BrighterScript Callfunc operator was missing, it causes crash when try to send telemetry.

"~~Member function not found in BrightScript Component or interface. (runtime error &hf4) in pkg:/components/roku_modules/datadogroku/core/MultiTrackUploaderTask.brs(237) ~~Backtrace: ~~
#3 Function datadogroku_handleresponse(requestid As String, responsecode As Integer, filepath As String, trackinfo As Object) As Voi$1 file/line: pkg:/components/roku_modules/datadogroku/core/MultiTrackUploaderTask.brs(237) ~~
#2 Function datadogroku_uploadavailablefilesfortrack(trackinfo As Object) As Voi$1 file/line: pkg:/components/roku_modules/datadogroku/core/MultiTrackUploaderTask.brs(66) ~~
#1 Function datadogroku_uploadavailablefiles() As Voi$1 file/line: pkg:/components/roku_modules/datadogroku/core/MultiTrackUploaderTask.brs(47) ~~
#0 Function datadogroku_uploaderloop() As Voi$1 file/line: pkg:/components/roku_modules/datadogroku/core/MultiTrackUploaderTask.brs(32) ~~Local Variables: ~~requestid roString (2.1 was String) refcnt=2 val:""40d5e629-a82f-400d-9701-f86e5f6e94ad"" ~~responsecode Integer val:202 (&hCA) ~~filepath roString (2.1 was String) refcnt=2 val:""cachefs:/datadog/v1/rum/1756616150006"" ~~trackinfo roAssociativeArray refcnt=4 count:6 ~~global Interface:ifGloba$1 m roAssociativeArray refcnt=5 count:5 ~~retry Boolean val:fals$1 message roString (2.1 was String) refcnt=1 val:""Unable to delete batch file at cachefs:/datadog/v1/rum/1756616150006"" ~~datadogrumagent roSGNode:datadogroku_RumAgent refcnt=1"

Motivation

RUM-11210

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested a review from a team as a code owner September 5, 2025 12:33
@ambushwork
ambushwork force-pushed the yl/fix-telemetry-crash branch from d76b932 to f8366b6 Compare September 5, 2025 12:34
@ambushwork
ambushwork force-pushed the yl/fix-telemetry-crash branch from f8366b6 to 82a065d Compare September 5, 2025 12:37
@ambushwork ambushwork changed the title RUM-11210: Add missing BrighterScript Callfunc Operator to fix crash RUMS-4872: Add missing BrighterScript Callfunc Operator to fix crash Sep 5, 2025
Comment thread library/components/core/MultiTrackUploaderTask.bs
@ambushwork
ambushwork changed the base branch from develop to release/1.3.0 September 8, 2025 07:22
@ambushwork
ambushwork requested a review from 0xnm September 8, 2025 07:25
@ambushwork
ambushwork merged commit 087ba2c into release/1.3.0 Sep 8, 2025
7 checks passed
@ambushwork
ambushwork deleted the yl/fix-telemetry-crash branch September 8, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants