[RUM 11576] [Modularization] Improve module wrapper singleton creation#970
Merged
marco-saia-datadog merged 1 commit intoSep 29, 2025
Conversation
marco-saia-datadog
previously approved these changes
Sep 3, 2025
sbarrio
dismissed
marco-saia-datadog’s stale review
September 3, 2025 07:56
The base branch was changed.
sbarrio
marked this pull request as ready for review
September 4, 2025 09:45
marco-saia-datadog
previously approved these changes
Sep 4, 2025
sbarrio
force-pushed
the
sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation
branch
from
September 8, 2025 10:18
5365857 to
ebe9212
Compare
sbarrio
force-pushed
the
sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation
branch
from
September 8, 2025 11:00
ebe9212 to
75212c2
Compare
marco-saia-datadog
previously approved these changes
Sep 9, 2025
sbarrio
dismissed
marco-saia-datadog’s stale review
September 22, 2025 14:14
The base branch was changed.
marco-saia-datadog
approved these changes
Sep 29, 2025
marco-saia-datadog
deleted the
sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation
branch
September 29, 2025 13:34
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the way in which we create our Module shared singleton instances to avoid potential collisions and instance regeneration when we start separating the core module into separate packages.
Motivation
This is groundwork for the core modularization effort.
Review checklist (to be filled by reviewers)