Remove unnecessary code signing settings for xcodebuild when running Unit Tests#831
Merged
marco-saia-datadog merged 2 commits intoMar 27, 2025
Conversation
marco-saia-datadog
approved these changes
Mar 27, 2025
marco-saia-datadog
deleted the
sbarrio/fix/remove-unnecessary-code-signing-settings-for-xcodebuild-on-unit-tests
branch
March 27, 2025 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While looking for the right way to fix our xcodebuild issues we tested several approaches, one of them being setting the
CODE_SIGN_ALLOWEDandCODE_SIGN_REQUIREDto YES. That approach however was not actually needed as the issue lied on on the required iOS version used on the simulator on which the test will run.That's why we can now do a bit of cleanup on the ci config and podfile installation settings.
Motivation
Remove unnecessary build settings.
Review checklist (to be filled by reviewers)