Skip to content

[Fix] Solve security issues raised by dependabot, linting and package.json cleanup#829

Merged
marco-saia-datadog merged 2 commits into
developfrom
sbarrio/fix/dependabot-security-warnings-and-package-cleanup
Mar 27, 2025
Merged

[Fix] Solve security issues raised by dependabot, linting and package.json cleanup#829
marco-saia-datadog merged 2 commits into
developfrom
sbarrio/fix/dependabot-security-warnings-and-package-cleanup

Conversation

@sbarrio

@sbarrio sbarrio commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

dependabot has raised several security issues related to octokit axios, and npm's nanoid, micromatch, send and serve-static. This PR forces resolutions for these to versions that solve those issues.

I also took the chance to solve two recently introduced linting issues as well as bumping some dependencies on the example app project.

Motivation

We should keep the SDK free of security impacted dependencies.

Additional Notes

A full e2e pipeline has been run to make sure that the forced resolutions do not crash on any of our supported React Native versions : https://gitlab.ddbuild.io/DataDog/dd-react-native-nightly-tests/-/pipelines/59570033/

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio
sbarrio force-pushed the sbarrio/fix/dependabot-security-warnings-and-package-cleanup branch from 48df8eb to cd61490 Compare March 21, 2025 16:34
…nimum versions for example dependencies | Solve linting issues

Solve linting issues
@sbarrio
sbarrio force-pushed the sbarrio/fix/dependabot-security-warnings-and-package-cleanup branch from cd61490 to f634a37 Compare March 24, 2025 15:30
@sbarrio
sbarrio marked this pull request as ready for review March 25, 2025 09:22
@sbarrio
sbarrio requested a review from a team as a code owner March 25, 2025 09:22
@sbarrio sbarrio self-assigned this Mar 25, 2025
@marco-saia-datadog
marco-saia-datadog merged commit 544b12c into develop Mar 27, 2025
@marco-saia-datadog
marco-saia-datadog deleted the sbarrio/fix/dependabot-security-warnings-and-package-cleanup branch March 27, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants