RUMM-2249, DOCS-3604 Add draft of crash reporting docs#229
Merged
louiszawadzki merged 7 commits intoJul 29, 2022
Conversation
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2249/crash-reporting-docs
branch
from
July 18, 2022 12:20
fc36fc9 to
673cd1f
Compare
louiszawadzki
marked this pull request as ready for review
July 18, 2022 12:20
hestonhoffman
added
the
editorial review
Contributor
|
Hello! I've opened an editorial review card for this one. |
alai97
suggested changes
Jul 19, 2022
alai97
changed the title
4 tasks
alai97
reviewed
Jul 20, 2022
louiszawadzki
commented
Jul 20, 2022
louiszawadzki
commented
Jul 20, 2022
louiszawadzki
commented
Jul 20, 2022
louiszawadzki
commented
Jul 20, 2022
louiszawadzki
commented
Jul 20, 2022
Co-authored-by: Austin Lai <[email protected]>
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2249/crash-reporting-docs
branch
from
July 20, 2022 08:33
f1c9935 to
8803792
Compare
alai97
approved these changes
Jul 20, 2022
0xnm
reviewed
Jul 21, 2022
|
|
||
| #### Manually on each build | ||
|
|
||
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. |
Member
There was a problem hiding this comment.
maybe we should also mention, that it will be not necessarily release folder in case if app has more comprehensive variants.
Contributor
There was a problem hiding this comment.
Suggested change
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. | |
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. If your application has more comprehensive variants, there may not be a `release` folder. |
alai97
reviewed
Jul 21, 2022
|
|
||
| #### Manually on each build | ||
|
|
||
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. |
Contributor
There was a problem hiding this comment.
Suggested change
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. | |
| On Android, the bundle file is located at `android/app/build/generated/assets/react/release/index.android.bundle` and the source map file is located at `android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`. If your application has more comprehensive variants, there may not be a `release` folder. |
louiszawadzki
commented
Jul 22, 2022
alai97
reviewed
Jul 22, 2022
Co-authored-by: Austin Lai <[email protected]>
alai97
approved these changes
Jul 26, 2022
Co-authored-by: Austin Lai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add documentation for crash reporting
Motivation
What inspired you to submit this pull request?
Additional Notes
Preview: https://docs-staging.datadoghq.com/alai97/react-native-crash-reporting-docs/real_user_monitoring/error_tracking/ios/?
https://docs-staging.datadoghq.com/alai97/react-native-crash-reporting-docs/real_user_monitoring/error_tracking/reactnative/
Review checklist (to be filled by reviewers)