[RUM-13676] [FIX] Babel: fix RUM Action report order#1097
Merged
Conversation
Contributor
|
Changing the target of this PR to V2 instead, as its a fix that should also be included there. |
cdn34dd
force-pushed
the
marcosaia/RUM-13676/fix-rum-action-report-order
branch
from
January 13, 2026 15:17
553ccfc to
65ed580
Compare
sbarrio
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates
wrapRumActionso that RUM actions are reported before executing the originalonClick/onTapcallback. The execution order of the wrapped interaction handlers is reversed for actions to be created at the correct time.Motivation
Previously, the plugin reported RUM actions only after the user-defined callback had finished executing. Since these callbacks can perform arbitrary logic and may introduce delays, the resulting action could be reported with an incorrect timestamp.
One observed consequence of this was tap actions for navigation buttons appearing in the RUM waterfall only after the view they navigate to.
Any delay or side effect inside the callback could cause the interaction to be recorded later than it actually occurred.
Reporting the action before executing the callback grants accurate timing and preserves the correct interaction order across all use cases.
Review checklist (to be filled by reviewers)