Skip to content

[CHORE] [V3] Refactor Initialization APIs#1089

Merged
sbarrio merged 9 commits into
feature/v3from
marcosaia/chore/refactor-init-apis
Jan 19, 2026
Merged

[CHORE] [V3] Refactor Initialization APIs#1089
sbarrio merged 9 commits into
feature/v3from
marcosaia/chore/refactor-init-apis

Conversation

@marco-saia-datadog

@marco-saia-datadog marco-saia-datadog commented Dec 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Refactored configurations into separate modules

    • Split configuration logic into multiple files and a nested folder structure.
    • This makes it easier to navigate between different supported SDK initialization types.

  • Support for initializing individual features with extra options

    • Feature configurations (core, RUM, logs, trace) now accept all required options as positional constructor arguments.
    • All optional configuration values are passed as the final positional argument as an object, allowing easier extensibility and clearer APIs.

  • Added missing properties in FileBasedConfiguration and AutoInstrumentationConfiguration

    • Fixed multiple configuration properties that were not being picked up from non-standard configs.
    • Updated tests to cover all supported configuration options and ensure correct mapping.

  • Implemented missing JSON converters in FileBasedConfiguration

    • Fixed cases where non-primitive values (e.g. enums) were assigned as raw values, which could lead to runtime issues.
    • All non-primitive types are now correctly parsed from the JSON configuration file.

  • Added missing tests and adjusted behavior

    • Introduced additional tests to cover edge cases and updated existing ones to reflect the new configuration behavior.

  • Removed unrelated cyclic dependency in network-instrumentation layer

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

sbarrio
sbarrio reviewed Jan 2, 2026
View reviewed changes
Comment thread packages/core/src/config/features/CoreConfiguration.ts
sbarrio
sbarrio reviewed Jan 2, 2026
View reviewed changes
Comment thread packages/core/src/config/features/CoreConfiguration.ts
sbarrio
sbarrio reviewed Jan 2, 2026
View reviewed changes
Comment thread packages/core/src/sdk/DatadogProvider/__tests__/initialization.test.tsx Outdated
sbarrio
sbarrio reviewed Jan 2, 2026
View reviewed changes
Comment thread packages/core/src/__tests__/DdSdkReactNativeConfiguration.test.ts
@sbarrio sbarrio mentioned this pull request Jan 5, 2026
Closed
4 tasks
@sbarrio
sbarrio changed the base branch from sbarrio/v3/refactor-configuration-properties to feature/v3 January 5, 2026 09:51
@sbarrio
sbarrio changed the base branch from feature/v3 to sbarrio/chore/update-v3-with-latest-from-develop January 7, 2026 11:41
Base automatically changed from sbarrio/chore/update-v3-with-latest-from-develop to feature/v3 January 8, 2026 09:09
@sbarrio
sbarrio marked this pull request as ready for review January 8, 2026 14:26
@sbarrio
sbarrio requested a review from a team as a code owner January 8, 2026 14:26
@sbarrio
sbarrio self-requested a review January 8, 2026 14:31
@sbarrio sbarrio self-assigned this Jan 9, 2026
cdn34dd
cdn34dd reviewed Jan 15, 2026
View reviewed changes
Comment thread packages/core/src/config/FileBasedConfiguration.ts Outdated
cdn34dd
cdn34dd reviewed Jan 15, 2026
View reviewed changes
Comment thread packages/core/src/config/FileBasedConfiguration.ts
cdn34dd
cdn34dd reviewed Jan 15, 2026
View reviewed changes
Comment thread packages/core/src/DdSdkReactNative.tsx
cdn34dd
cdn34dd previously approved these changes Jan 15, 2026
View reviewed changes

@cdn34dd cdn34dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, just left a couple of comments regarding some implementation details.

@sbarrio
sbarrio force-pushed the marcosaia/chore/refactor-init-apis branch from fe04870 to 5c8097b Compare January 16, 2026 14:01
@sbarrio
sbarrio requested a review from cdn34dd January 16, 2026 14:01
cdn34dd
cdn34dd previously approved these changes Jan 16, 2026
View reviewed changes
@sbarrio
sbarrio force-pushed the marcosaia/chore/refactor-init-apis branch 2 times, most recently from dc77522 to 6faaae6 Compare January 16, 2026 14:55
@sbarrio
sbarrio changed the base branch from feature/v3 to sbarrio/v3/update-with-latest-from-v2 January 19, 2026 11:22
@sbarrio
sbarrio changed the base branch from sbarrio/v3/update-with-latest-from-v2 to feature/v3 January 19, 2026 11:22
@sbarrio
sbarrio dismissed cdn34dd’s stale review January 19, 2026 11:22

The base branch was changed.

@sbarrio
sbarrio force-pushed the marcosaia/chore/refactor-init-apis branch from 6faaae6 to 39e339b Compare January 19, 2026 11:28
@sbarrio
sbarrio requested a review from a team as a code owner January 19, 2026 11:28
@sbarrio
sbarrio changed the base branch from feature/v3 to sbarrio/v3/update-with-latest-from-v2 January 19, 2026 11:28
@sbarrio
sbarrio changed the base branch from sbarrio/v3/update-with-latest-from-v2 to feature/v3 January 19, 2026 11:33
@sbarrio
sbarrio changed the base branch from feature/v3 to sbarrio/v3/update-with-latest-from-v2 January 19, 2026 11:34
@sbarrio
sbarrio requested a review from cdn34dd January 19, 2026 11:46
sbarrio and others added 9 commits January 19, 2026 14:09
@sbarrio
Move resourceTraceSampleRate, nativeLongTaskThreshold, nativeCrashRep…
888a3b8 
…ortingEnabled and useAccesibilityLabel to rumConfiguration
@sbarrio
Fix iOS tests
a8e832b
@sbarrio
Fix Android tests
9b584d8
@sbarrio
Expose optional Rum, Logs and Trace configuration objects on DatadogP…
f2df627 
…roviderConfiguration
@sbarrio
Configuration constructor now retains default values
a5b4c4f
@marco-saia-datadog @sbarrio
Refactored Initialization APIs and configs
6cf49b9 
* Refactored configurations and split them in separate modules
* Allow initialization of individual features with extra options
* Added missing properties in FileBasedConfiguration
* Implemented missing JSON converters in FileBasedConfiguration
* Fixed missing properties in various setups
* Added missing tests and adjusted behavior
@marco-saia-datadog @sbarrio
review: using parsed RN version in test snapshot
731d0a8
@sbarrio
Ensure SDK does not crash if module configuration is missing
a2fc28e 
Cleanup

Add missing configuration on benchmark app
@sbarrio
Changes from PR comments
6cfc1bd
@sbarrio
sbarrio force-pushed the marcosaia/chore/refactor-init-apis branch from 39e339b to 6cfc1bd Compare January 19, 2026 13:11
cdn34dd
cdn34dd previously approved these changes Jan 19, 2026
View reviewed changes
Base automatically changed from sbarrio/v3/update-with-latest-from-v2 to feature/v3 January 19, 2026 15:24
@sbarrio
sbarrio dismissed cdn34dd’s stale review January 19, 2026 15:24

The base branch was changed.

@sbarrio
sbarrio requested a review from cdn34dd January 19, 2026 15:24
@sbarrio
sbarrio merged commit 1522dc9 into feature/v3 Jan 19, 2026
9 checks passed
@sbarrio
sbarrio deleted the marcosaia/chore/refactor-init-apis branch January 19, 2026 15:30
@sbarrio sbarrio mentioned this pull request Jan 22, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdn34dd cdn34dd cdn34dd approved these changes
@sbarrio sbarrio Awaiting requested review from sbarrio

Assignees

@sbarrio sbarrio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marco-saia-datadog @sbarrio @cdn34dd