[RUM-11767] Rename last_failure_status ddtag to retry_after#2808
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoApr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames the last_failure_status ddtag to retry_after across all request builders to align with the RUM intake specification and Browser SDK convention. The change affects network request query parameters when handling retry logic.
Changes:
- Renamed the ddtag from
last_failure_statustoretry_afterin four request builders (RUM, Session Replay Segment, Session Replay Resource, and Profiling) - Added test coverage for the retry code path in Session Replay and Profiling request builders
- Updated existing RUM test to expect the new tag name
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DatadogRUM/Sources/Feature/RequestBuilder.swift | Renamed last_failure_status to retry_after in ddtags |
| DatadogRUM/Tests/Feature/RequestBuilderTests.swift | Updated test assertion to verify new tag name |
| DatadogSessionReplay/Sources/Feature/RequestBuilders/SegmentRequestBuilder.swift | Renamed last_failure_status to retry_after in ddtags |
| DatadogSessionReplay/Sources/Feature/RequestBuilders/ResourceRequestBuilder.swift | Renamed last_failure_status to retry_after in ddtags |
| DatadogSessionReplay/Tests/Feature/RequestBuilder/SegmentRequestBuilderTests.swift | Added test for retry query parameters with new tag name |
| DatadogSessionReplay/Tests/Feature/RequestBuilder/ResourceRequestBuilderTests.swift | Added test for retry query parameters with new tag name |
| DatadogProfiling/Sources/RequestBuilder.swift | Renamed last_failure_status to retry_after in ddtags |
| DatadogProfiling/Tests/RequestBuilderTests.swift | Added test for retry query parameters with new tag name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
saraSr5
marked this pull request as ready for review
April 7, 2026 13:14
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
sara.susano/RUM-11767/add-retry-after-ddtag
branch
April 8, 2026 10:52
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Rename the
last_failure_statusddtag toretry_afterin theddtagsquery parameter to align with the RUM intake spec and Browser SDK convention.How?
Updated all request builders that previously appended
last_failure_status:<code>to useretry_after:<code>instead:DatadogRUM/Sources/Feature/RequestBuilder.swiftDatadogSessionReplay/Sources/Feature/RequestBuilders/SegmentRequestBuilder.swiftDatadogSessionReplay/Sources/Feature/RequestBuilders/ResourceRequestBuilder.swiftDatadogProfiling/Sources/RequestBuilder.swiftAdded missing test coverage for the
retry_aftercode path in the Session Replay and Profiling request builders.Review checklist
make api-surfacewhen adding new APIs