Skip to content

RUM-14563 Add header capture configuration API and HeaderProcessor#2699

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
feature/header-capturefrom
bplasovska/RUM-14563/header-capture-api
Mar 2, 2026
Merged

RUM-14563 Add header capture configuration API and HeaderProcessor#2699
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
feature/header-capturefrom
bplasovska/RUM-14563/header-capture-api

Conversation

@barboraplasovska

@barboraplasovska barboraplasovska commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

What and why?

This is the first PR for Network Header Capture. It adds the public configuration API (TrackResourceHeaders, HeaderCaptureRule) on URLSessionTracking to let users opt into capturing HTTP request and response headers on RUM resources. It also introduces HeaderProcessor, which resolves the capture list from configuration rules, applies security filtering (regex-based sensitive header detection, reserved iOS headers exclusion), and enforces size limits. RUM models are regenerated to include request.headers and response.headers on RUMResourceEvent.

Follow-up PR will wire the processor into the resource interception pipeline.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs - see our guidelines (internal)
  • Run make api-surface when adding new APIs

@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-14563/header-capture-api branch 3 times, most recently from 32442e6 to 9c6814a Compare February 17, 2026 15:30
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Feb 17, 2026

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5b2ceec | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-14563/header-capture-api branch from 9c6814a to 7638924 Compare February 18, 2026 09:31
@barboraplasovska barboraplasovska self-assigned this Feb 18, 2026
@barboraplasovska
barboraplasovska marked this pull request as ready for review February 18, 2026 13:16
@barboraplasovska
barboraplasovska requested a review from a team as a code owner February 18, 2026 13:16

@mariedm mariedm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👌

I believe this PR should add an entry to the changelog since it's introducing a new customer-facing option. Also, given that it's public but not yet wired to the resource pipeline, it should be merged to a feature branch instead of develop.

Comment thread DatadogRUM/Sources/RUMConfiguration.swift
Comment thread DatadogRUM/Sources/RUMConfiguration.swift Outdated
Comment thread DatadogRUM/Sources/RUMConfiguration.swift Outdated
Comment thread DatadogRUM/Sources/Instrumentation/Resources/HeaderCapture/HeaderProcessor.swift Outdated
Comment thread DatadogRUM/Sources/RUMConfiguration.swift Outdated
@barboraplasovska
barboraplasovska changed the base branch from develop to feature/header-capture February 20, 2026 14:45
Comment thread DatadogRUM/Sources/RUM+objc.swift
@barboraplasovska
barboraplasovska requested a review from a team as a code owner February 27, 2026 09:50

@mariedm mariedm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@barboraplasovska

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 2, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-02 09:40:49 UTC ℹ️ Start processing command /merge


2026-03-02 09:40:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in feature/header-capture is approximately 0s (p90).


2026-03-02 09:41:28 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 1349091 into feature/header-capture Mar 2, 2026
18 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bplasovska/RUM-14563/header-capture-api branch March 2, 2026 09:41
@simaoseica-dd simaoseica-dd mentioned this pull request Mar 11, 2026
@barboraplasovska
barboraplasovska restored the bplasovska/RUM-14563/header-capture-api branch April 24, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants