Skip to content

Propagate feature flags to fatal error RUM events#2688

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
developfrom
valpertui/fix/missing-flags-in-crashes
Feb 17, 2026
Merged

Propagate feature flags to fatal error RUM events#2688
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
developfrom
valpertui/fix/missing-flags-in-crashes

Conversation

@Valpertui

@Valpertui Valpertui commented Feb 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix missing featureFlags propagation in FatalErrorBuilder when constructing RUM error and view events for crashes, fatal app hangs, and watchdog terminations
  • Feature flags present on the last RUM view were silently dropped in the resulting events sent to the backend
  • Add test coverage for feature flags propagation in CrashReportReceiverTests

Changes

  • FatalErrorBuilder.createRUMError(): pass featureFlags from the last RUMViewEvent to the RUMErrorEvent
  • FatalErrorBuilder.updateRUMViewWithError(): preserve featureFlags from the original RUMViewEvent
  • RUMDataModelMocks: thread featureFlags parameter through mockRandomWith()
  • CHANGELOG.md: add [FIX] entry under Unreleased

Test plan

  • New test testGivenCrashDuringRUMSessionWithActiveViewAndFeatureFlags_itSendsEventsWithFeatureFlags verifies both error and view events propagate feature flags
  • All 25 existing CrashReportReceiverTests pass (no regressions)
  • SwiftLint passes with 0 violations

🤖 Generated with Claude Code

@Valpertui
Valpertui requested a review from a team as a code owner February 10, 2026 21:25
@Valpertui Valpertui mentioned this pull request Feb 10, 2026
Merged
3 tasks
simaoseica-dd
simaoseica-dd approved these changes Feb 11, 2026
View reviewed changes

@simaoseica-dd simaoseica-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Valpertui

Valpertui commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-11 10:15:51 UTC ℹ️ Start processing command /merge

2026-02-11 10:15:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-11 14:19:12 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Valpertui
Valpertui force-pushed the valpertui/fix/missing-flags-in-crashes branch from 4e48766 to e900e03 Compare February 12, 2026 14:14
@Valpertui @claude
Propagate feature flags to fatal error RUM events
9cdcaf5 
FatalErrorBuilder omitted featureFlags when constructing RUM error and
view events for crashes, fatal app hangs, and watchdog terminations.
This caused feature flags present on the last RUM view to be lost in
the resulting error/view events sent to the backend.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@Valpertui
Valpertui force-pushed the valpertui/fix/missing-flags-in-crashes branch from e900e03 to 9cdcaf5 Compare February 17, 2026 10:25
@Valpertui

Valpertui commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-17 13:04:06 UTC ℹ️ Start processing command /merge

2026-02-17 13:04:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 2h (p90).

2026-02-17 14:52:30 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 61c3068 into develop Feb 17, 2026
18 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the valpertui/fix/missing-flags-in-crashes branch February 17, 2026 14:52
@mariedm mariedm mentioned this pull request Feb 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariedm mariedm mariedm approved these changes
@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Valpertui @mariedm @simaoseica-dd