Skip to content

FFL-1460 FlagsClient changes to accommodate Flags RN SDK sync flag evals #2604

Merged
dd-mergequeue[bot] merged 16 commits into
developfrom
dima/FFL-1460-sync-flag-evaluation-in-rn-sdk
Jan 6, 2026
Merged

FFL-1460 FlagsClient changes to accommodate Flags RN SDK sync flag evals #2604
dd-mergequeue[bot] merged 16 commits into
developfrom
dima/FFL-1460-sync-flag-evaluation-in-rn-sdk

Conversation

@yugisu-flux

@yugisu-flux yugisu-flux commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What and why?

The motivation for this work is to allow the upcoming Flags RN SDK to be able to retrieve complete feature flags state to the JS side at init time (FFL-1460).

This has been developed in parallel with changes in:

How?

Changes:

  • FlagsClient method for retrieving all feature flags from a FlagsClient.
  • FlagsClient method for exposure tracking and RUM logging that will be exposed to the RN SDK.

Please note that the above changes are for internal Datadog usage and are not meant to be used by the wider public.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)
  • The changes in this PR are not a part of "public" interface.

@yugisu-flux yugisu-flux self-assigned this Dec 3, 2025
@yugisu-flux
yugisu-flux requested a review from a team as a code owner December 3, 2025 13:01
@yugisu-flux
yugisu-flux force-pushed the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch from e333fd2 to 13803c4 Compare December 3, 2025 13:04
@yugisu-flux yugisu-flux mentioned this pull request Dec 3, 2025
Merged
4 tasks
@yugisu-flux
yugisu-flux force-pushed the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch from e7a9778 to ca3ce44 Compare December 3, 2025 13:53
@yugisu-flux
yugisu-flux requested review from dd-oleksii and ncreated and removed request for dd-oleksii December 3, 2025 13:53
@yugisu-flux yugisu-flux changed the title FFL-1460 Add a FlagsClient method that allows to retrieve all fetched flags FFL-1460 FlagsClient changes to accommodate Flags RN SDK sync flag evals Dec 3, 2025
typotter
typotter reviewed Dec 3, 2025
View reviewed changes
Comment thread DatadogFlags/Sources/Client/FlagsClient.swift Outdated
sameerank
sameerank reviewed Dec 4, 2025
View reviewed changes

@sameerank sameerank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some thoughts about the tests. Overall looks good and happy to approve after those are addressed, but would be better if Guille has a chance to take a look too

Comment thread DatadogFlags/Tests/Client/FlagsClientTests.swift Outdated
Comment thread DatadogFlags/Tests/Client/FlagsClientTests.swift
sameerank
sameerank reviewed Dec 4, 2025
View reviewed changes
Comment thread DatadogFlags/Sources/Client/FlagsClientProtocol.swift Outdated
gonzalezreal
gonzalezreal reviewed Dec 4, 2025
View reviewed changes

@gonzalezreal gonzalezreal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left a couple of suggestions. Let me know your thoughts.

Comment thread DatadogFlags/Sources/Client/FlagsClient.swift Outdated
Comment thread DatadogFlags/Sources/Client/FlagsClient.swift Outdated
Comment thread DatadogFlags/Sources/Client/FlagsClientProtocol.swift Outdated
@datadog-official

This comment has been minimized.

Sign in to view
sameerank
sameerank reviewed Dec 8, 2025
View reviewed changes
Comment thread DatadogFlags/Sources/Client/FlagsClient.swift Outdated
Comment thread DatadogFlags/Sources/Client/FlagsClientProtocol.swift Outdated
@yugisu-flux
yugisu-flux requested a review from sameerank December 9, 2025 17:13
gonzalezreal
gonzalezreal approved these changes Dec 15, 2025
View reviewed changes

@gonzalezreal gonzalezreal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ncreated ncreated mentioned this pull request Dec 17, 2025
Merged
4 tasks
@yugisu-flux

yugisu-flux commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-06 13:35:31 UTC ℹ️ Start processing command /merge

2026-01-06 13:35:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 60m (p90).

2026-01-06 13:39:51 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit a80b782:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@yugisu-flux

yugisu-flux commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-06 14:54:34 UTC ℹ️ Start processing command /merge

2026-01-06 14:54:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 60m (p90).

2026-01-06 16:15:23 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 2b88d49:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@yugisu-flux

yugisu-flux commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

Using the merge queue is rough, stuff fails or hangs up randomly. Third time's a charm.

@yugisu-flux

yugisu-flux commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-06 16:35:00 UTC ℹ️ Start processing command /merge

2026-01-06 16:35:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 60m (p90).

2026-01-06 16:36:03 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 2f28ab9 into develop Jan 6, 2026
18 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch January 6, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonzalezreal gonzalezreal gonzalezreal approved these changes
@ncreated ncreated Awaiting requested review from ncreated
@typotter typotter Awaiting requested review from typotter
@sameerank sameerank Awaiting requested review from sameerank

Assignees

@yugisu-flux yugisu-flux

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yugisu-flux @gonzalezreal @sameerank @typotter