RUM-11648: Fix LogEvent device types#2474
Merged
simaoseica-dd merged 3 commits intoSep 17, 2025
Merged
Conversation
0xnm
previously approved these changes
Sep 16, 2025
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm! need to update API surface file as well
0xnm
approved these changes
Sep 16, 2025
mariedm
approved these changes
Sep 16, 2025
urseberry
approved these changes
Sep 16, 2025
simaoseica-dd
deleted the
simaoseica/RUM-11648/fix-logevent-device-property
branch
September 17, 2025 08:30
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
This PR aligns the Objective-C device type used in
Logswith the centralized Swift Device model.This ensures consistency across features and helps clients correctly use the Objective-C Logs APIs, such as the Kotlin Multiplatform SDK.
How?
It updates the Objective-C
LogEvent.deviceanddd.deviceparameters to match the current Swift models.Review checklist
make api-surface)