Skip to content

Add missing versionMajor property to the DDLogEventOperatingSystem definition in Objective-C#2463

Merged
dd-mergequeue[bot] merged 1 commit into
developfrom
nogorodnikov/add-missing-versionmajor-to-logevent-objc
Sep 8, 2025
Merged

Add missing versionMajor property to the DDLogEventOperatingSystem definition in Objective-C#2463
dd-mergequeue[bot] merged 1 commit into
developfrom
nogorodnikov/add-missing-versionmajor-to-logevent-objc

Conversation

@0xnm

@0xnm 0xnm commented Sep 5, 2025

Copy link
Copy Markdown
Member

What and why?

This PR adds a missing property which exists in the Swift model, but not in Objective-C.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@0xnm
0xnm requested review from a team as code owners September 5, 2025 15:14
@0xnm

0xnm commented Sep 5, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-05 15:30:54 UTC ℹ️ Start processing command /merge

2025-09-05 15:31:16 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-05 19:32:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@0xnm

0xnm commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-08 07:17:49 UTC ℹ️ Start processing command /merge

2025-09-08 07:17:54 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-09-08 07:56:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit a409e0e into develop Sep 8, 2025
18 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the nogorodnikov/add-missing-versionmajor-to-logevent-objc branch September 8, 2025 07:56
@barboraplasovska barboraplasovska mentioned this pull request Sep 15, 2025
Merged
4 tasks
@simaoseica-dd simaoseica-dd mentioned this pull request Sep 18, 2025
Merged
@0xnm 0xnm mentioned this pull request Sep 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariedm mariedm mariedm approved these changes
@janine-c janine-c janine-c approved these changes
@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @mariedm @janine-c @simaoseica-dd