Skip to content

RUM-7316 Expose Session Replay SwiftUI Feature Flag to Objc#2145

Merged
dd-mergequeue[bot] merged 1 commit into
developfrom
maxep/RUM-7316/swiftui-ff
Dec 13, 2024
Merged

RUM-7316 Expose Session Replay SwiftUI Feature Flag to Objc#2145
dd-mergequeue[bot] merged 1 commit into
developfrom
maxep/RUM-7316/swiftui-ff

Conversation

@maxep

@maxep maxep commented Dec 12, 2024

Copy link
Copy Markdown
Member

What and why?

Follow up #2124

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@maxep
maxep requested review from a team as code owners December 12, 2024 17:46
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: maxep/RUM-7316/swiftui-ff
Commit report: c92cc3b
Test service: dd-sdk-ios

✅ 0 Failed, 3583 Passed, 0 Skipped, 2m 31.43s Total Time
🔻 Test Sessions change in coverage: 4 decreased, 3 increased, 7 no change

🔻 Code Coverage Decreases vs Default Branch (4)

  • test DatadogInternalTests iOS 80.48% (-0.06%) - Details
  • test DatadogInternalTests tvOS 80.46% (-0.05%) - Details
  • test DatadogTraceTests iOS 54.12% (-0.04%) - Details
  • test DatadogCoreTests iOS 71.88% (-0.02%) - Details

simaoseica-dd
simaoseica-dd previously approved these changes Dec 12, 2024
View reviewed changes
@maxep
maxep force-pushed the maxep/RUM-7316/swiftui-ff branch from c24476b to ba8e1af Compare December 13, 2024 09:18
@maxep
maxep force-pushed the maxep/RUM-7316/swiftui-ff branch from ba8e1af to c92cc3b Compare December 13, 2024 10:00
@maxep

maxep commented Dec 13, 2024

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow

dd-devflow Bot commented Dec 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-13 10:34:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in develop is 28m.

2024-12-13 11:01:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 41aa68a into develop Dec 13, 2024
@mariedm
mariedm deleted the maxep/RUM-7316/swiftui-ff branch December 17, 2024 09:25
@maciejburda maciejburda mentioned this pull request Jan 2, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxep @simaoseica-dd