RUM-7316 Session Replay SwiftUI Feature Flag#2124
Conversation
040a14d to
9faa288
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3561 Passed, 0 Skipped, 2m 21.83s Total Time 🔻 Code Coverage Decreases vs Default Branch (2) |
| /// - touchPrivacyLevel: The way user touches (e.g. tap) should be masked. Default: `.hide`. | ||
| /// - startRecordingImmediately: If the recording should start automatically. When `true`, the recording starts automatically; when `false` it doesn't, and the recording will need to be started manually. Default: `true`. | ||
| /// - customEndpoint: Custom server url for sending replay data. Default: `nil`. | ||
| /// - featureFlags: Experimental feature flags. |
There was a problem hiding this comment.
Do we intentionally not add this param to the deprecated API? I think it makes sense, but double-checking just in case.
There was a problem hiding this comment.
I did it intentionally, yes. I think it makes sense to not add features to deprecated api 👍
| ] | ||
| // swiftlint:enable opening_brace | ||
| // disable swiftui based on ff | ||
| if !featureFlags[.swiftui, default: false] { |
There was a problem hiding this comment.
nit: we could make it a bit easier to read with a computer property
extension SessionReplay.Configuration.FeatureFlags {
var isSwiftUIDisabled: Bool {
return !self[.swiftui, default: false]
}
}
There was a problem hiding this comment.
Good idea, I have something more generic:
public subscript(flag: Key) -> Bool {
self[flag, default: false]
}
9faa288 to
a1aaee1
Compare
|
/merge |
Devflow running:
|
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
2 participants
What and why?
Enable SwiftUI recording using a feature-flag
How?
Defines
SessionReplay.Configuration.FeatureFlagswith.swiftuidisabled by default.Review checklist
make api-surface)