Skip to content

chore: Add signed commits requirement to CONTRIBUTING.md#1709

Merged
ncreated merged 1 commit into
developfrom
ncreated-patch-1
Mar 6, 2024
Merged

chore: Add signed commits requirement to CONTRIBUTING.md#1709
ncreated merged 1 commit into
developfrom
ncreated-patch-1

Conversation

@ncreated

@ncreated ncreated commented Mar 6, 2024

Copy link
Copy Markdown
Member

What and why?

📦 As we require all commits to be signed, this PR updates CONTRIBUTING.md with this note.

How?

Updated CONTRIBUTING.md.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

to include a note on signing commits
@ncreated ncreated self-assigned this Mar 6, 2024
@ncreated
ncreated requested review from a team as code owners March 6, 2024 12:46

@maxep maxep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncreated
ncreated merged commit f3b9a8f into develop Mar 6, 2024
@ncreated
ncreated deleted the ncreated-patch-1 branch March 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants