RUM-419 Report Application Build Number#1465
Conversation
fff26e3 to
7e3759c
Compare
| let applicationBuildNumber = configuration.bundle.object(forInfoDictionaryKey: "CFBundleVersion") as? String | ||
| ?? "0" |
There was a problem hiding this comment.
❓
I don't recall exactly (it has been long time since I published an app) but can this be different than App Store build number?
If yes, then I expect build number (as well as application version) part of configuration (plain strings).
So the final resolutions looks like
- try from configuration string value
- try from bundle
- null (either missing from the payload or explicitly marked as
nulljson value.)
❓ why is this a required field?
There was a problem hiding this comment.
The build_version is a required field, same for the version field. We have not exposed an application version parameter in the core config, and I believe it should be the same for the build number.
They are both corresponding to values in the app store, but since we are getting them from the Bundle with optional casting to String, we have a fallback value that won't be reached in production.
There was a problem hiding this comment.
I don't recall exactly (it has been long time since I published an app) but can this be different than App Store build number?
I explained our rationale here. In a nutshell:
CFBundleShortVersionString=MARKETING_VERSION= what users see in App StoreCFBundleVersion=CURRENT_PROJECT_VERSION= what devs see in App Store
7c46b35 to
8bb2e53
Compare
Datadog ReportBranch report: ✅ |
f90a33b to
87a9d8b
Compare
What and why?
Send
build_numberfield as part of RUM and Logs.fix #1026
Review checklist
Custom CI job configuration (optional)